Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert [SDK-2183] Add warning when requested scopes differ from retrieved scopes #712

Merged
merged 2 commits into from
Mar 8, 2021

Conversation

frederikprijck
Copy link
Member

@frederikprijck frederikprijck commented Mar 3, 2021

This PR revert the console warning that was added as part of #665 based on feedback received in #709.

The user reporting that issue shows that having a difference in requested vs retrieved scopes can be expected and results in unwanted console warnings.

Note: I didnt use an actual revert commit as that PR include unrelated changes to the test scripts that we want to keep.

@frederikprijck frederikprijck requested a review from a team as a code owner March 3, 2021 10:40
@stevehobbsdev stevehobbsdev added CH: Fixed PR is fixing a bug review:small Small review labels Mar 8, 2021
@stevehobbsdev stevehobbsdev added this to the vNext milestone Mar 8, 2021
@stevehobbsdev stevehobbsdev linked an issue Mar 8, 2021 that may be closed by this pull request
@stevehobbsdev stevehobbsdev merged commit f9da419 into master Mar 8, 2021
@stevehobbsdev stevehobbsdev deleted the frederik/revert-sdk-2183 branch March 8, 2021 15:04
@stevehobbsdev stevehobbsdev mentioned this pull request Mar 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CH: Fixed PR is fixing a bug review:small Small review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Option to hide missing scopes warning
2 participants