[SDK-2172] Add SDK metrics to all API calls #659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevehobbsdev
requested changes
Dec 2, 2020
Comment on lines
193
to
198
| 'Auth0-Client': btoa( | ||
| JSON.stringify({ | ||
| name: 'auth0-spa-js', | ||
| version: version | ||
| }) | ||
| ) |
There was a problem hiding this comment.
As we're adding coverage here, it would be worth adding the same assertions on the headers for the test that follows ("..when using refresh tokens"). Looks like an omission testing for one but not the other, even though in reality we know both are covered.
There was a problem hiding this comment.
Ye I thought about it, wasn't sure and decided to not pollute all tests with it. But I think I can add it.
There was a problem hiding this comment.
Updated the PR to address this. Also added it on a few more places and used DEFAUKT_AUTH0_CLIENT where appropriate
stevehobbsdev
approved these changes
Dec 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The requests to the /token endpoint did not include the
Auth0-Clientheader, making it harder to pull metrics from our data.This PR ensures the token endpoint gets added the appropriate header in the following situations: