[SDK-1858] Create legacy samsite cookie by default #568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/Auth0Client.ts
Outdated
| @@ -128,13 +133,18 @@ export default class Auth0Client { | |||
| private tokenIssuer: string; | |||
| private defaultScope: string; | |||
| private scope: string; | |||
| private CookieStorage: ClientStorage; | |||
There was a problem hiding this comment.
What's the reason for making this Title Case? Could we follow convention for other class-level props?
There was a problem hiding this comment.
I was generally using the convention SomeNewThingTitleCase = SomeThingTitleCase || SomeOtherThingTitleCase; - but sure, I can change to camel case
stevehobbsdev
approved these changes
Sep 2, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a legacy SameSite cookie (one without SameSite set to 'None') for legacy browsers.
Also adding the option to turn this off (to avoid browser console warning) with the caveat that this will break silent auth for incompatible clients https://www.chromium.org/updates/same-site/incompatible-clients
References
See https://web.dev/samesite-cookie-recipes/#handling-incompatible-clients
Fixes #515
Testing
Checklist
master