[SDK-1912] Unnecessary latency in getTokenSilently with primed cache
#558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamjmcgrath
commented
Aug 26, 2020
| @@ -155,7 +154,7 @@ describe('Auth0', () => { | |||
| }); | |||
|
|
|||
| afterEach(() => { | |||
| jest.resetAllMocks(); | |||
| jest.clearAllMocks(); | |||
There was a problem hiding this comment.
resetAllMocks destroys the localStorage mock (which browser-tabs-lock uses in these tests) clarkbw/jest-localstorage-mock#83
Had to fix some leaky tests after removing it
adamjmcgrath
commented
Aug 26, 2020
| ); | ||
|
|
||
| if (cache && cache.access_token) { | ||
| await lock.releaseLock(GET_TOKEN_SILENTLY_LOCK_KEY); |
There was a problem hiding this comment.
This will be called in the finally so shouldn't be called here
stevehobbsdev
approved these changes
Aug 26, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Check the cache before acquiring lock to avoid latency when the cache is populated (see #552)
Check the cache after acquiring lock to prevent unnecessary requests, because a previous call might have populated the cache while the current call was waiting to acquire the lock (see #480)
References
fixes #552
Testing
To check #552:
Call
getTokenSilentlywith a primed cache, latency should be <20msCheck regression of #480:
Hammer the
getTokenSilentlybutton in the SPA js playground with "Use token cache when fetching new tokens" enabled and check that only one token is requestedChecklist
master