Mark redirect_uri optional on RedirectLoginOptions #53
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When configuring a global redirect_uri (by passing it as a property on Auth0ClientOptions to the Auth0Client constructor), passing a redirect uri is not required when calling
loginWithRedirect
(I think it will even be ignored if you do so: https://github.com/auth0/auth0-spa-js/blob/master/src/Auth0Client.ts#L67).However, the typings have marked redirect_uri as required for
RedirectLoginOptions
.This PR ensures the property is marked optional.
Testing
The samples from the Angular quickstart guide don't compile for me, for example the AuthGuard has this code:
Which gives me the following TSC error:
Checklist
master