Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDK-1125] createAuth0Client now throws errors that are not login_required #369

Merged
merged 1 commit into from
Mar 3, 2020

Conversation

stevehobbsdev
Copy link
Contributor

Description

Errors on start up thrown by getTokenSilently should be exposed if they are anything other than login_required. This may help diagnose configuration issues that might be difficult to debug if the developer has to wait 60 seconds to see them (thanks to the auth timeout when using an iframe and response_mode: web_message.

References

Fixes #208

Testing

  • This change adds test coverage for new/changed/fixed functionality

Checklist

  • I have added documentation for new/changed functionality in this PR or in auth0.com/docs
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used, if not master

@stevehobbsdev stevehobbsdev added this to the vNext milestone Mar 3, 2020
@stevehobbsdev stevehobbsdev requested a review from a team March 3, 2020 11:48
@stevehobbsdev stevehobbsdev added the CH: Fixed PR is fixing a bug label Mar 3, 2020
@stevehobbsdev stevehobbsdev merged commit 0b997dd into master Mar 3, 2020
@stevehobbsdev stevehobbsdev deleted the fix/init-errors branch March 3, 2020 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CH: Fixed PR is fixing a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Throw Explicit errors on failure when bootstrapping
2 participants