Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release v1.4.1 #262

Merged
merged 1 commit into from
Oct 30, 2019
Merged

Release v1.4.1 #262

merged 1 commit into from
Oct 30, 2019

Conversation

stevehobbsdev
Copy link
Contributor

No description provided.

@stevehobbsdev stevehobbsdev requested a review from a team October 30, 2019 20:06
@stevehobbsdev stevehobbsdev merged commit 14a2ca6 into master Oct 30, 2019
@stevehobbsdev stevehobbsdev deleted the prepare/1.4.1 branch October 30, 2019 20:10
@damieng
Copy link
Contributor

damieng commented Oct 30, 2019

Would have been nice to have gotten #260 into this release.

@stevehobbsdev
Copy link
Contributor Author

@damieng We're going to have to put out another one very shortly anyway. Is #260 ready to go? Looks like it's awaiting changes.

@lbalmaceda
Copy link
Contributor

260 is good to go unless you find an alternate, more cleaner way of doing that parseInt call. We need to keep support for string type because that was released a while ago.

@snyk-bot snyk-bot mentioned this pull request Nov 8, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luisrudge luisrudge luisrudge approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@stevehobbsdev @damieng @lbalmaceda @luisrudge