Fix for race condition when using sha256
on IE11
#252
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an issue with resolving SHA256 operations in IE11.
msCrypto (IE11) uses the old spec, which is not Promise based. Instead of returning a promise, it returns a CryptoOperation
with a result property in it.
As a result, the various events need to be handled in the event that we're working in IE11 (hence the msCrypto check). These events just call resolve or reject depending on the handler.
The
sha256
function essentially now has two clear paths depending on IE11 vs. not-IE11 - either return the promise from the browser's crypto API, or return a new promise which is resolved or rejected based on the events raised bymsCrypto
.References
CryptoOperation reference: https://msdn.microsoft.com/en-us/expression/dn904640(v=vs.71)
Testing
Checklist
master