-
Notifications
You must be signed in to change notification settings - Fork 364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a new property 'fragment' to be appended to the authorize URL on redirect #249
Add a new property 'fragment' to be appended to the authorize URL on redirect #249
Conversation
Please refer to auth0/auth0-spa-js#249
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@willhackett - Appreciate the contribution here and in Docs!
This looks good to me but I'm going to leave this for the platform maintainers to make sure this public API addition makes sense to them.
2eb02de
to
ef2faa6
Compare
ef2faa6
to
b07aec4
Compare
@luisrudge if preferred, this is also an option: |
Hey @willhackett, appreciate your patience with this. We'd like to go for option 2 (88ac957). Would you be able to rework the PR (or feel free to raise a new one) with that? Thanks for the contribution! |
d02f378
to
b682266
Compare
b682266
to
1abedea
Compare
Description
In some circumstances the URL may need to be mutated post-generation. An example use case is adding parameters to the hash (
#
) part of the URL in order to more safely transmit personally identifiable information.I've added a new public method to return the URL instead of merely redirecting.
Potential use:
References
Testing
Call the
buildLoginUrl
method available onAuth0Client
.Checklist
master