Pkce challenge code empty #221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luisrudge
approved these changes
Sep 23, 2019
|
@benprime thank you so much for reporting and sending a PR with this. I did some changes to fix the IE11 issue (that's when we introduced this bug). 🎉 |
|
@luisrudge Not a problem! Thanks for the quick merge! |
|
Released in 1.2.4 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix to resolve #216 by updating utility method that is causing a blank
challenge_codeto be provided to the authorize endpoint.Testing
Test added to verify
bufferToBase64UrlEncodedreturns correct value. It was returning a blank string previously.Checklist
master.