Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug where oauth/token call ignores options.audience #134

Merged
merged 4 commits into from
Aug 6, 2019
Merged

Fix bug where oauth/token call ignores options.audience #134

merged 4 commits into from
Aug 6, 2019

Conversation

luisrudge
Copy link
Contributor

@luisrudge luisrudge commented Aug 2, 2019 •
edited
Loading

Description

While doing #133, I noticed loginWithPopup and getTokenSilently were ignoring the options.audience param in the oauth/token call. This PR fixes this issue.

@luisrudge luisrudge added the small label Aug 2, 2019
@luisrudge luisrudge requested a review from a team August 2, 2019 20:13
@luisrudge luisrudge changed the title Add missing test case for ignoreCache:true Fix bug where oauth/token call ignores options.audience Aug 2, 2019
@luisrudge luisrudge merged commit 590bf56 into master Aug 6, 2019
@damieng damieng deleted the fix/missing-test branch August 21, 2019 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lbalmaceda lbalmaceda lbalmaceda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@luisrudge @lbalmaceda @joshcanhelp