Add popup config option to prevent closing the popup #1319
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR adds a new optional boolean
suppressPopupClose
field to thePopupConfigOptions
interface. When true, this prevents therunPopup
util func used byloginWithPopup
from closing the popup window after receiving theauthorization_response
message.There are two main ways this might be used:
loginWithPopup
is complete, you could change the href of the popup to whatever post-login page you want.(Note: in both scenarios, it is assumed the
popup
is also being passed in the config options, so that it can be managed outside ofloginWithPopup
)I've also added a section to the FAQs that discusses using this option for login in Chrome extensions (as well as a brief discussion of logout for extensions, which is not directly impacted by this change but is related and was lacking documentation)
References
Closes #1318
Testing
Checklist