Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make TransactionManager use CookieDomain #1105

Merged
merged 1 commit into from
Jun 2, 2023
Merged

Make TransactionManager use CookieDomain #1105

merged 1 commit into from
Jun 2, 2023

Conversation

ZdravkoDonev-gtmhub
Copy link
Contributor

…orage

Changes

Modified the TransactionManager class to receive an optional cookieDomain?: string parameter.
When the Auth0 application is created, in the Auth0ClientOptions the user can pass cookieDomain. The changes reflect the fact the currently the TransactionManager ignores that option. With this change the TransactionManager, when instantiated with CookieStorage, will use the cookieDomain parameter.

References

Testing

  • This change adds unit test coverage
  • This change adds integration test coverage
  • This change has been tested on the latest version of the platform/language

Checklist

@ZdravkoDonev-gtmhub ZdravkoDonev-gtmhub requested a review from a team as a code owner June 2, 2023 09:26
@ZdravkoDonev-gtmhub ZdravkoDonev-gtmhub mentioned this pull request Jun 2, 2023
Closed
6 tasks
frederikprijck
frederikprijck approved these changes Jun 2, 2023
View reviewed changes
Copy link
Member

@frederikprijck frederikprijck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@frederikprijck frederikprijck changed the title Bug Fix: Make TransactionManager use CookieDomain when using CookieSt… Make TransactionManager use CookieDomain Jun 2, 2023
@frederikprijck frederikprijck merged commit f7594e5 into auth0:master Jun 2, 2023
@frederikprijck frederikprijck mentioned this pull request Jun 2, 2023
Merged
@gardnern gardnern mentioned this pull request Jun 19, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frederikprijck frederikprijck frederikprijck approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ZdravkoDonev-gtmhub @frederikprijck