Check if iframe is still in body before removing (#399)

If the iframe is removed from the DOM prior to the timeout it would error on removeChild. Error thrown: `Uncaught DOMException: Failed to execute 'removeChild' on 'Node': The node to be removed is not a child of this node.` Bug introduced in #376 Co-authored-by: Steve Hobbs <[email protected]>
auth0 · Apr 15, 2020 · 7b04165 · 7b04165
1 parent 55d479e
commit 7b04165
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/__tests__/utils.test.ts b/__tests__/utils.test.ts
@@ -621,6 +621,7 @@ describe('utils', () => {
         expect(type).toBe('iframe');
         return iframe;
       });
+      window.document.body.contains = () => true;
       window.document.body.appendChild = jest.fn();
       window.document.body.removeChild = jest.fn();
       return { iframe, url, origin };

diff --git a/src/utils.ts b/src/utils.ts
@@ -55,10 +55,16 @@ export const runIframe = (
     iframe.setAttribute('width', '0');
     iframe.setAttribute('height', '0');
     iframe.style.display = 'none';
+
+    const removeIframe = () => {
+      if (window.document.body.contains(iframe)) {
+        window.document.body.removeChild(iframe);
+      }
+    };
 
     const timeoutSetTimeoutId = setTimeout(() => {
       rej(TIMEOUT_ERROR);
-      window.document.body.removeChild(iframe);
+      removeIframe();
     }, timeoutInSeconds * 1000);
 
     const iframeEventHandler = function(e: MessageEvent) {
@@ -71,7 +77,7 @@ export const runIframe = (
       // Delay the removal of the iframe to prevent hanging loading status
       // in Chrome: https://github.com/auth0/auth0-spa-js/issues/240
       setTimeout(
-        () => window.document.body.removeChild(iframe),
+        removeIframe,
         CLEANUP_IFRAME_TIMEOUT_IN_SECONDS * 1000
       );
     };