Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SDK-1693] Renames #21

Merged
merged 3 commits into from
May 28, 2020
Merged

[SDK-1693] Renames #21

merged 3 commits into from
May 28, 2020

Conversation

adamjmcgrath
Copy link
Contributor

@adamjmcgrath adamjmcgrath commented May 28, 2020 •
edited
Loading

Description

Methods renames:
login -> loginWithRedirect
withLoginRequired -> withAuthenticationRequired
getToken -> getAccessTokenSilently
getTokenWithPopup -> getAccessTokenWithPopup

prop renames
isLoading -> !isReady (I've put this in a separate commit because I'm not convinced it's the right way to go) Removed from this PR

(thank god for TypeScript ;P)

README:
Remove 'Advanced' use cases title
add audience/scope to access api readme

Checklist

  • I have added documentation for new/changed functionality in this PR or in auth0.com/docs
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used, if not master

@adamjmcgrath adamjmcgrath added small This PR may require low effort to action, or contains few changes to review CH: Breaking Change PR contains breaking changes without a major version bump labels May 28, 2020
@adamjmcgrath adamjmcgrath requested a review from a team May 28, 2020 11:43
@adamjmcgrath adamjmcgrath changed the title Renames [SDK-1693] Renames May 28, 2020
@adamjmcgrath adamjmcgrath merged commit d4832b1 into master May 28, 2020
@evansims evansims deleted the renames branch July 5, 2022 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevehobbsdev stevehobbsdev stevehobbsdev approved these changes

Assignees
No one assigned
Labels
CH: Breaking Change PR contains breaking changes without a major version bump small This PR may require low effort to action, or contains few changes to review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adamjmcgrath @stevehobbsdev