Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to OkHttp 3.14.9 #262

Merged
merged 2 commits into from
May 27, 2020
Merged

Update to OkHttp 3.14.9 #262

merged 2 commits into from
May 27, 2020

Conversation

jimmyjames
Copy link
Contributor

Changes

  • Updates to OkHttp 3.14.9, continuing the work started in Upgrade okhttp3 to latest #231.
  • Updates RecordedRequestMatcher.matchesQueryParameter to use the HttpUrl and query methods instead of parsing the path manually. Also enables tests to expect the unencoded query parameter values.

References

See the discussion on #231 for context and background regarding OkHttp changes to query parameter encoding (tl;dr - Since v3.10.0 more characters are being encoded).

Testing

  • This change adds test coverage
  • This change has been tested on the latest version of the platform/language or why not

Checklist

@jimmyjames jimmyjames requested a review from a team May 27, 2020 20:03
@jimmyjames jimmyjames merged commit 2439ebb into auth0:master May 27, 2020
@jimmyjames jimmyjames mentioned this pull request May 27, 2020
5 tasks
@jimmyjames jimmyjames modified the milestones: v1-Next, 1.17.0, 1.18.0 May 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants