Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use char array for passwords #242

Merged
merged 2 commits into from
Apr 8, 2020
Merged

Use char array for passwords #242

merged 2 commits into from
Apr 8, 2020

Conversation

jimmyjames
Copy link
Contributor

Changes

Fixes #234

Included changes:

  • Use a character array (char[]) instead of String for password fields

Changes to follow, not in this PR:

  • Deprecation of String-based password APIs. Will be done in separate PR for changelog and tracking purposes

References

Testing

Please describe how this can be tested by reviewers. Be specific about anything not tested and reasons why. If this library has unit and/or integration testing, tests should be added for new functionality and existing tests should complete without errors.

  • This change adds test coverage
  • This change has been tested on the latest version of the platform/language or why not

Checklist

@jimmyjames jimmyjames added this to the v1-Next milestone Apr 7, 2020
@jimmyjames jimmyjames requested a review from a team April 7, 2020 01:45
lbalmaceda
lbalmaceda approved these changes Apr 7, 2020
View reviewed changes
Copy link
Contributor

@lbalmaceda lbalmaceda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/main/java/com/auth0/client/auth/AuthAPI.java Show resolved Hide resolved
@jimmyjames jimmyjames merged commit 5575342 into auth0:master Apr 8, 2020
@jimmyjames jimmyjames mentioned this pull request Apr 8, 2020
Merged
5 tasks
@jimmyjames jimmyjames modified the milestones: v1-Next, 1.16.0 Apr 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lbalmaceda lbalmaceda lbalmaceda approved these changes

Assignees
No one assigned
Labels
CH: Added CH: Security
Projects
None yet
Milestone
1.16.0
Development

Successfully merging this pull request may close these issues.

Sensitive data in a String object, making it impossible to reliably purge the data from memory
2 participants
@jimmyjames @lbalmaceda