Add Job "POST User Exports" endpoint #241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimmyjames
previously approved these changes
Apr 6, 2020
|
Yes, my intention was to add them to this PR. Let me mark it as in progress. |
lbalmaceda
force-pushed
the
add-user-exports
branch
from
08e10ab to
8ac1bf2
Compare
lbalmaceda
commented
Apr 7, 2020
| @JsonProperty("export_as") | ||
| private String exportAs; | ||
|
|
||
| public UsersExportField(String name) { |
There was a problem hiding this comment.
Keeping this one handy as seems to be the default scenario. If the alternative constructor is not required, I can replace it with a setter for export_as
| @@ -117,7 +119,7 @@ public void jsonResponse(String path, int statusCode) throws IOException { | |||
| server.enqueue(response); | |||
| } | |||
|
|
|||
| public void rateLimitReachedResponse(long limit, long remaining, long reset) throws IOException { | |||
There was a problem hiding this comment.
linter pointed out exceptions not thrown, and auto-closing of buffer (with jdk 8 try/catch)
|
I'm working on adding the import users endpoint to this PR. |
|
I'm going to keep this one for the User Exports endpoint and add the remaining endpoints in separate PRs. |
lbalmaceda
changed the title
lbalmaceda
force-pushed
the
add-user-exports
branch
from
2fd3297 to
f735f89
Compare
damieng
approved these changes
Apr 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Adds the following endpoint:
References
Will close #95
Testing
Checklist