Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing metadata field to Connection object #206

Merged
merged 1 commit into from
May 9, 2019
Merged

Add missing metadata field to Connection object #206

merged 1 commit into from
May 9, 2019

Conversation

AlisonT1230
Copy link

Pull request for issue #205

  • Modified Connection class to contain a new metadata field
  • Added sample metadata to existing test case with Connection object
  • Added sample metadata to existing MockServer test resource file

@AlisonT1230 AlisonT1230 marked this pull request as ready for review May 9, 2019 20:19
@AlisonT1230 AlisonT1230 requested a review from a team May 9, 2019 20:19
@AlisonT1230 AlisonT1230 mentioned this pull request May 9, 2019
Closed
lbalmaceda
lbalmaceda approved these changes May 9, 2019
View reviewed changes
Copy link
Contributor

@lbalmaceda lbalmaceda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lbalmaceda lbalmaceda added this to the v1-Next milestone May 9, 2019
@lbalmaceda lbalmaceda merged commit 246c34e into auth0:master May 9, 2019
@AlisonT1230 AlisonT1230 deleted the Connection-metadata branch May 9, 2019 21:32
@lbalmaceda lbalmaceda changed the title Add metadata field to Connection object Add missing metadata field to Connection object May 22, 2019
@lbalmaceda lbalmaceda modified the milestones: v1-Next, 1.13.3 May 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lbalmaceda lbalmaceda lbalmaceda approved these changes

Assignees
No one assigned
Labels
CH: Fixed
Projects
None yet
Milestone
1.13.3
Development

Successfully merging this pull request may close these issues.
2 participants
@AlisonT1230 @lbalmaceda