Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "mark_email_as_verified" property to PasswordChangeTicket #189

Merged
merged 2 commits into from Mar 11, 2019
Merged

Add "mark_email_as_verified" property to PasswordChangeTicket #189

merged 2 commits into from Mar 11, 2019

Conversation

ghost
Copy link

@ghost ghost commented Mar 5, 2019

Hi Auth0 Team,

according to the Management API v2 documentation, /password-change endpoint accepts a new extra parameter, namely mark_email_as_verified. The current version of auth0-java client API is missing this feature.

We would like to utilize this feature in our service and use the official client library.

Thank you in advance.

Best regards,
Yevhenii.

Changes

A new field has been added to the class definition and a corresponding unit test has been updated.

References

Management API v2: Create a password change ticket

Testing

Although the change is really small and is covered by a test, I performed a small local test and creating a password change ticket using the patched auth0-java library:

import com.auth0.client.mgmt.ManagementAPI
import com.auth0.json.mgmt.tickets.PasswordChangeTicket

fun main(){
    val management = ManagementAPI("domain", "token");
    val ticket = PasswordChangeTicket("userid")
    ticket.setMarkEmailAsVerified(true);
    val response = management.tickets().requestPasswordChange(ticket).execute();
    print("Your ticket is" + response.ticket)
}
  • This change adds test coverage
  • This change has been tested on the latest version of the platform/language

Checklist

Copy link
Contributor

@lbalmaceda lbalmaceda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A single change and I'll merge it. Tests are fine already 👍

@ghost
Copy link
Author

ghost commented Mar 8, 2019

@lbalmaceda thanks a lot for your review. When could we expect this change to be released?

@lbalmaceda lbalmaceda added this to the v1-Next milestone Mar 11, 2019
@lbalmaceda
Copy link
Contributor

By eow at the most. Thanks!

@lbalmaceda lbalmaceda merged commit d1720b0 into auth0:master Mar 11, 2019
@lbalmaceda lbalmaceda modified the milestones: v1-Next, 1.11.0 Mar 14, 2019
@ghost ghost deleted the add-password-change-ticket-mark-email-as-verified-property branch March 29, 2019 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant