Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close ResponseBody buffer after read #101

Merged
merged 1 commit into from
Dec 27, 2017
Merged

Close ResponseBody buffer after read #101

merged 1 commit into from
Dec 27, 2017

Conversation

lbalmaceda
Copy link
Contributor

Wish I could test this in an easy way but that would require extending OkHttp classes to store the "closed" state.
Will fix #100

@lbalmaceda lbalmaceda added this to the v1-Next milestone Dec 26, 2017
@lbalmaceda lbalmaceda requested a review from cocojoe December 26, 2017 21:15
Copy link
Member

@cocojoe cocojoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lbalmaceda lbalmaceda merged commit 5d83ed8 into master Dec 27, 2017
@lbalmaceda lbalmaceda deleted the fix-buffer-state branch December 27, 2017 12:46
@lbalmaceda lbalmaceda modified the milestones: v1-Next, 1.5.1 Mar 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Connection leakage - during VoidRequest processing its response body wasn't closed
2 participants