update v3.4.3

autarc · Nov 7, 2016 · 8616b9b · 8616b9b
1 parent 0ef0ac8
commit 8616b9b
Show file tree

Hide file tree

Showing 5 changed files with 9 additions and 6 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,7 +1,8 @@
-# [v3.4.2]
-> November 7, 2016
+# [v3.4.3]
+> November 8, 2016
 
 - improve browser compatibility
+- add workaround for [non-standard NamedNodeMap behaviour](https://github.com/ariya/phantomjs/issues/14634)
 
 
 ## [v3.4.1]

diff --git a/dist/optimal-select.js b/dist/optimal-select.js
@@ -1472,7 +1472,9 @@ return /******/ (function(modules) { // webpackBootstrap
 	        var attributes = Object.keys(elementAttributes).reduce(function (attributes, key) {
 	          var attribute = elementAttributes[key];
 	          var attributeName = attribute.name;
-	          if (attributeName !== 'class') {
+	          // NOTE: workaround detection for non-standard phantomjs NamedNodeMap behaviour
+	          // (issue: https://github.com/ariya/phantomjs/issues/14634)
+	          if (attribute && attributeName !== 'class') {
 	            attributes[attributeName] = attribute.value;
 	          }
 	          return attributes;

diff --git a/dist/optimal-select.min.js b/dist/optimal-select.min.js
diff --git a/dist/optimal-select.min.js.map b/dist/optimal-select.min.js.map
diff --git a/package.json b/package.json
@@ -1,7 +1,7 @@
 {
   "name": "optimal-select",
   "description": "Get efficient & robust CSS selectors for HTML elements",
-  "version": "3.4.2",
+  "version": "3.4.3",
   "author": "Stefan Dühring | Autarc <[email protected]>",
   "bugs": {
     "url": "https://github.com/Autarc/optimal-select/issues"