fix: use 'dns:///' instead of 'dns://' (flyteorg#274)

austin362667 · May 7, 2024 · 5da7d46 · 5da7d46
1 parent 9b07409
commit 5da7d46
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/flytectl/cmd/configuration/configuration.go b/flytectl/cmd/configuration/configuration.go
@@ -58,7 +58,7 @@ var prompt = promptui.Select{
 	Items: []string{"S3", "GCS"},
 }
 
-var endpointPrefix = [3]string{"dns://", "http://", "https://"}
+var endpointPrefix = [3]string{"dns:///", "http://", "https://"}
 
 // CreateConfigCommand will return configuration command
 func CreateConfigCommand() *cobra.Command {
@@ -95,7 +95,7 @@ func initFlytectlConfig(ctx context.Context, reader io.Reader) error {
 		if !validateEndpointName(trimHost) {
 			return errors.New("Please use a valid endpoint")
 		}
-		templateValues.Host = fmt.Sprintf("dns://%s", trimHost)
+		templateValues.Host = fmt.Sprintf("dns:///%s", trimHost)
 		templateValues.Insecure = initConfig.DefaultConfig.Insecure
 		templateStr = configutil.AdminConfigTemplate
 		if initConfig.DefaultConfig.Storage {

diff --git a/flytectl/cmd/configuration/configuration_test.go b/flytectl/cmd/configuration/configuration_test.go
@@ -65,7 +65,7 @@ func TestSetupConfigFunc(t *testing.T) {
 }
 
 func TestTrimFunc(t *testing.T) {
-	assert.Equal(t, trimEndpoint("dns://localhost"), "localhost")
+	assert.Equal(t, trimEndpoint("dns:///localhost"), "localhost")
 	assert.Equal(t, trimEndpoint("http://localhost"), "localhost")
 	assert.Equal(t, trimEndpoint("https://localhost"), "localhost")
 }