fix(win): fix plugin startup / use FileAppender #45
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issues on reading the plugin startup message when using system threads over tokio tasks, seem to be due to the RollingFileAppender
Built locally on a mac m1 (via docker) and tested in a windows VM using parallels
Plugin now start ups correctly, and maintains logs. fixes #42
Using the pact-plugin-driver with this change
https://github.com/pact-foundation/pact-plugins/pull/69/files#diff-e21b8ae9cb59f07bada083f39629f6fbc221a1c6ca0ad395799d0bad5f7bc941R290
in order to terminate child processes on windows, will fix the shut down issues.
Tested e2e with the avro plugin example in https://github.com/pact-foundation/pact-go/tree/master/examples/avro