Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐞 Site language option not working. #12

Closed
bennyxguo opened this issue Mar 31, 2021 · 0 comments
Closed

🐞 Site language option not working. #12

bennyxguo opened this issue Mar 31, 2021 · 0 comments
Assignees
@bennyxguo
Labels
bug Something isn't working

Comments

@bennyxguo
Copy link
Member

bennyxguo commented Mar 31, 2021 •
edited
Loading

Problem
The locale setting did not take effect when set. After investigation, this is caused by the router guard logic, where it change the locale basic on checking the router params.

Solution
Changed the logic to use the stored locale in appStore, and set it to the stored locale in the beforeEach callback.
@bennyxguo bennyxguo added the bug Something isn't working label Mar 31, 2021
@bennyxguo bennyxguo self-assigned this Mar 31, 2021
bennyxguo added a commit that referenced this issue Apr 1, 2021
@bennyxguo
Fixed the site language setting not taking effect (#12)
f2cc13e
@bennyxguo bennyxguo moved this to Published in Hexo Aurora 2.x Roadmap Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bennyxguo bennyxguo

Labels
bug Something isn't working
Projects
Hexo Aurora 2.x Roadmap
Archived in project
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bennyxguo