feat(aureliaCLICommands): add au run to command pallet #24
Conversation
|
|
| @@ -12,6 +12,7 @@ export default class AureliaCliCommands { | |||
| vscode.commands.registerCommand('extension.auGenerate', () => this.auGenerate(outputChannel)), | |||
| vscode.commands.registerCommand('extension.auTest', () => this.runCommand(['test'], outputChannel, false)), | |||
| vscode.commands.registerCommand('extension.auBuild', () => this.auBuild(outputChannel))); | |||
There was a problem hiding this comment.
Thanks for the pull request!
If you add the line above the auBuild line or change the above line to end on (outputChannel)), and the new line on outputChannel, true))); then the build will succeed.
You could test if the build succeeds by running npm run build on your local machine, once you done a npm install.
Then we can take a look and test it :-)
There was a problem hiding this comment.
Oops, my bad. I didn't see that I had added a trailing comma after the statement was completed; and sadly I didn't run the build after making the changes. I did run the tests however, but of course no tests hit this file. This is my first pull request anywhere. Hopefully my next one will be better. :-)
There was a problem hiding this comment.
I looked over the helloworld vscode extension example/docs and noticed I had forgot to expose the command in the package.json. I've tested with F5 and it's there now.
There was a problem hiding this comment.
I just looked over my code after going through the hello world vscode extension sample and noticed that I needed to update the package.json to expose the new command... in two places. Tested and confirmed to run auRun >> au run.
SteveHartzog
force-pushed
the
run-command
branch
from
9b61c27 to
9a1aa74
Compare
Add au run command to the command pallet. feat(aureliaCLICommands): add au run to command pallet Add au run command to the command pallet. feat(aureliaCLICommands): add au run to command pallet Add au run command to the command pallet
SteveHartzog
force-pushed
the
run-command
branch
from
e1d3f86 to
f1388fd
Compare
Needed to expose auRun command via activationEvents.
|
Tested & merged it. Thank you for helping out improving the visual studio code Aurelia experience! |
|
Just released a new version 0.1.11, which includes your change, sorry for the delay. Thank you for the contribution to making the Aurelia vs code editor experience great! |
Add au run command to the command pallet. Did I miss anything or is that it?