Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auto-complete stopped working in 0.1.5 release #7

Closed
eriklieben opened this issue Oct 12, 2016 · 2 comments
Closed

Auto-complete stopped working in 0.1.5 release #7

eriklieben opened this issue Oct 12, 2016 · 2 comments
Assignees
@eriklieben
Labels
bug

Comments

@eriklieben
Copy link
Contributor

eriklieben commented Oct 12, 2016 •
edited
Loading

I'm submitting a bug report

  • VSCode Version:
    1.6.0

Library Version:
0.1.5

  • Operating System:
    Windows 10

Auto-complete stopped working in 0.1.5 release.
@eriklieben eriklieben added the bug label Oct 12, 2016
@eriklieben eriklieben self-assigned this Oct 12, 2016
@eriklieben
Copy link
Contributor Author

Seems to be partially fixed with the v1.6.1 release, which reversed some changes made in vscode (https://github.com/Microsoft/vscode/milestone/31?closed=1).

Still, it now requires you to type value.b instead of only value. to get auto suggestion.

Need to look into it to find a fix for this/ see what changed.

@eriklieben eriklieben mentioned this issue Oct 16, 2016
Closed
eriklieben pushed a commit that referenced this issue Oct 22, 2016
fix(autocomplete): implement language server with default auto comple…
49656b5 
…tes resolves #4 #7  (#11)

* feat(completion): removed client completion functionallity

* feat(all): base language server implementation

* fix(all): remove unneeded util files

* feat(autocomple): improved auto-complete and moved processing to seperate process

* fix(autocomplete): added descriptions for custom tags

* feat(autocomplete): Add autocomplete for matcher attribute on select element

* fix(autocomplete): remove close tag completion, already handled by html language service

* refactor(autocomplete): completions from strings to sets

* refactor(autocomplete): move classes to seperate files to cleanup provider

* fix(autocomplete): don't add attributes that are already added by the default html auto complete

* feat(autocomplete): add event auto-complete

* fix(autocomplete): use global events set on html elements, see https://developer.mozilla.org/en-US/docs/Web/API/GlobalEventHandlers
@eriklieben
Copy link
Contributor Author

fixed in 0.1.7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eriklieben eriklieben

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@eriklieben