forked from quarkusio/quarkus
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Don't ignore Spring Rest controllers interfaces if contains errors
Related to quarkusio#43704
- Loading branch information
1 parent
d99e142
commit 886b8da
Showing
2 changed files
with
60 additions
and
5 deletions.
There are no files selected for viewing
48 changes: 48 additions & 0 deletions
48
...rc/test/java/io/quarkus/spring/web/test/UnbuildableSpringRestControllerInterfaceTest.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,48 @@ | ||
package io.quarkus.spring.web.test; | ||
|
||
import static org.assertj.core.api.Assertions.assertThat; | ||
import static org.assertj.core.api.Assertions.fail; | ||
|
||
import jakarta.ws.rs.QueryParam; | ||
|
||
import org.junit.jupiter.api.Test; | ||
import org.junit.jupiter.api.extension.RegisterExtension; | ||
import org.springframework.web.bind.annotation.GetMapping; | ||
import org.springframework.web.bind.annotation.PostMapping; | ||
import org.springframework.web.bind.annotation.RequestMapping; | ||
import org.springframework.web.bind.annotation.RequestParam; | ||
import org.springframework.web.bind.annotation.RestController; | ||
|
||
import io.quarkus.test.QuarkusProdModeTest; | ||
|
||
public class UnbuildableSpringRestControllerInterfaceTest { | ||
|
||
@RegisterExtension | ||
static final QuarkusProdModeTest config = new QuarkusProdModeTest() | ||
.withApplicationRoot((jar) -> jar | ||
.addClasses(UnbuildableControllerInterface.class)) | ||
.setApplicationName("unbuildable-rest-controller-interface") | ||
.setApplicationVersion("0.1-SNAPSHOT") | ||
.assertBuildException(throwable -> { | ||
assertThat(throwable).isInstanceOf(RuntimeException.class); | ||
assertThat(throwable).hasMessageContaining( | ||
"Cannot have more than one of @PathParam, @QueryParam, @HeaderParam, @FormParam, @CookieParam, @BeanParam, @Context on method"); | ||
}); | ||
|
||
@Test | ||
public void testBuildLogs() { | ||
fail("Should not be called"); | ||
} | ||
|
||
@RestController | ||
@RequestMapping("/unbuildable") | ||
public interface UnbuildableControllerInterface { | ||
@GetMapping("/ping") | ||
String ping(); | ||
|
||
@PostMapping("/hello") | ||
String hello(@RequestParam(required = false) @QueryParam("dung") String params); | ||
|
||
} | ||
|
||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters