Don't ignore Spring Rest controllers interfaces if contains errors

Related to quarkusio#43704

extensions/spring-web/core/deployment/src/main/java/io/quarkus/spring/web/deployment/SpringRestControllerAnnotationHandler.java

@@ -0,0 +1,17 @@
+package io.quarkus.spring.web.deployment;
+
+import org.jboss.jandex.ClassInfo;
+import org.jboss.jandex.DotName;
+import org.jboss.resteasy.reactive.common.processor.EndpointAnnotationHandler;
+
+public class SpringRestControllerAnnotationHandler implements EndpointAnnotationHandler {
+    public static final DotName SPRING_REST_CONTROLLER = DotName
+            .createSimple("org.springframework.web.bind.annotation.RestController");
+
+    @Override
+    public boolean isEndpointAnnotationValid(ClassInfo classInfo) {
+        return classInfo
+                .declaredAnnotation(SPRING_REST_CONTROLLER) != null;
+    }
+
+}

extensions/spring-web/resteasy-reactive/tests/src/test/java/io/quarkus/spring/web/resteasy/reactive/test/UnbuildableSpringRestControllerInterfaceTest.java

@@ -0,0 +1,48 @@
+package io.quarkus.spring.web.resteasy.reactive.test;
+
+import static org.assertj.core.api.Assertions.assertThat;
+import static org.assertj.core.api.Assertions.fail;
+
+import jakarta.ws.rs.QueryParam;
+
+import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.extension.RegisterExtension;
+import org.springframework.web.bind.annotation.GetMapping;
+import org.springframework.web.bind.annotation.PostMapping;
+import org.springframework.web.bind.annotation.RequestMapping;
+import org.springframework.web.bind.annotation.RequestParam;
+import org.springframework.web.bind.annotation.RestController;
+
+import io.quarkus.test.QuarkusProdModeTest;
+
+public class UnbuildableSpringRestControllerInterfaceTest {
+
+    @RegisterExtension
+    static final QuarkusProdModeTest config = new QuarkusProdModeTest()
+            .withApplicationRoot((jar) -> jar
+                    .addClasses(UnbuildableControllerInterface.class))
+            .setApplicationName("unbuildable-rest-controller-interface")
+            .setApplicationVersion("0.1-SNAPSHOT")
+            .assertBuildException(throwable -> {
+                assertThat(throwable).isInstanceOf(RuntimeException.class);
+                assertThat(throwable).hasMessageContaining(
+                        "Cannot have more than one of @PathParam, @QueryParam, @HeaderParam, @FormParam, @CookieParam, @BeanParam, @Context on method");
+            });
+
+    @Test
+    public void testBuildLogs() {
+        fail("Should not be called");
+    }
+
+    @RestController
+    @RequestMapping("/unbuildable")
+    public interface UnbuildableControllerInterface {
+        @GetMapping("/ping")
+        String ping();
+
+        @PostMapping("/hello")
+        String hello(@RequestParam(required = false) @QueryParam("dung") String params);
+
+    }
+
+}

independent-projects/resteasy-reactive/common/processor/src/main/java/org/jboss/resteasy/reactive/common/processor/DefaultEndpointAnnotationHandler.java

@@ -0,0 +1,18 @@
+package org.jboss.resteasy.reactive.common.processor;
+
+import java.lang.reflect.Modifier;
+
+import org.jboss.jandex.ClassInfo;
+
+public class DefaultEndpointAnnotationHandler implements EndpointAnnotationHandler {
+    public DefaultEndpointAnnotationHandler() {
+    }
+
+    @Override
+    public boolean isEndpointAnnotationValid(ClassInfo classInfo) {
+        if (Modifier.isInterface(classInfo.flags()) || Modifier.isAbstract(classInfo.flags())) {
+            return true;
+        }
+        return false;
+    }
+}

independent-projects/resteasy-reactive/common/processor/src/main/java/org/jboss/resteasy/reactive/common/processor/EndpointAnnotationHandler.java

@@ -0,0 +1,9 @@
+package org.jboss.resteasy.reactive.common.processor;
+
+import org.jboss.jandex.ClassInfo;
+
+public interface EndpointAnnotationHandler {
+
+    boolean isEndpointAnnotationValid(ClassInfo classInfo);
+
+}

independent-projects/resteasy-reactive/common/processor/src/main/java/org/jboss/resteasy/reactive/common/processor/EndpointIndexer.java

@@ -97,6 +97,7 @@
 import java.util.Map;
 import java.util.Objects;
 import java.util.Optional;
+import java.util.ServiceLoader;
 import java.util.Set;
 import java.util.function.Consumer;
 import java.util.function.Function;
@@ -324,7 +325,7 @@ public Optional<ResourceClass> createEndpoints(ClassInfo classInfo, boolean cons
 
             return Optional.of(clazz);
         } catch (Exception e) {
-            if (Modifier.isInterface(classInfo.flags()) || Modifier.isAbstract(classInfo.flags())) {
+            if (isEndpointValid(classInfo)) {
                 //kinda bogus, but we just ignore failed interfaces for now
                 //they can have methods that are not valid until they are actually extended by a concrete type
                 log.debug("Ignoring interface " + classInfo.name(), e);
@@ -334,6 +335,13 @@ public Optional<ResourceClass> createEndpoints(ClassInfo classInfo, boolean cons
         }
     }
 
+    private boolean isEndpointValid(ClassInfo classInfo) {
+        EndpointAnnotationHandler defaultEndpointAnnotationHandler = new DefaultEndpointAnnotationHandler();
+        return ServiceLoader.load(EndpointAnnotationHandler.class).findFirst()
+                .orElse(defaultEndpointAnnotationHandler).isEndpointAnnotationValid(classInfo);
+
+    }
+
     private String sanitizePath(String path) {
         // this simply replaces the whitespace characters (not part of a path variable) with %20
         // TODO: this might have to be more complex, URL encoding maybe?