Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor #162 #198

Merged
merged 4 commits into from
Feb 4, 2022
Merged

Refactor #162 #198

merged 4 commits into from
Feb 4, 2022

Conversation

koriym
Copy link
Member

@koriym koriym commented Feb 4, 2022

The nesting of if was not easy to read, so I created a method.

See 66333fa

@codecov-commenter
Copy link

codecov-commenter commented Feb 4, 2022

Codecov Report

❗ No coverage uploaded for pull request base (3.x@a4fd8dc). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##             3.x     #198   +/-   ##
======================================
  Coverage       ?   99.87%           
  Complexity     ?      279           
======================================
  Files          ?       34           
  Lines          ?      809           
  Branches       ?        0           
======================================
  Hits           ?      808           
  Misses         ?        1           
  Partials       ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4fd8dc...66333fa. Read the comment docs.

@koriym koriym marked this pull request as ready for review February 4, 2022 06:57
@harikt harikt merged commit 84b0a18 into auraphp:3.x Feb 4, 2022
@harikt
Copy link
Member

harikt commented Feb 4, 2022

Thank you @koriym .

@koriym koriym deleted the inline_array branch February 4, 2022 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants