Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ignore() method to common Insert class #173

Merged
merged 1 commit into from
Feb 4, 2022
Merged

Add ignore() method to common Insert class #173

merged 1 commit into from
Feb 4, 2022

Conversation

maximTarleckiy
Copy link

@maximTarleckiy maximTarleckiy changed the base branch from 3.x to 2.x January 16, 2020 12:34
@harikt
Copy link
Member

harikt commented Feb 4, 2022

I agree with you. It looks orIgnore seems to be used inside update also.

Only question here is do we want to use $inser->ignore() or $inser->orIgnore().

@harikt harikt requested a review from koriym February 4, 2022 08:37
@harikt harikt changed the base branch from 2.x to 3.x February 4, 2022 08:37
@koriym koriym merged commit b6a0a49 into auraphp:3.x Feb 4, 2022
@NaokiTsuchiya
Copy link

LGTM

@harikt
Copy link
Member

harikt commented Feb 4, 2022

@koriym , @NaokiTsuchiya please do make sure other methods are also changed.

@koriym
Copy link
Member

koriym commented Feb 4, 2022

@harikt Sorry we missed it.

@harikt
Copy link
Member

harikt commented Feb 4, 2022

As we move to 3.x BC is not an issue. But I wish we could address using ignore or ignoreOr

@koriym
Copy link
Member

koriym commented Feb 5, 2022

@harikt orIgnore method marked @deprecated?

@harikt
Copy link
Member

harikt commented Feb 6, 2022

That is the change in this PR. But I doubt about it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koriym koriym koriym approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@maximTarleckiy @harikt @NaokiTsuchiya @koriym