Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove restriction requiring FROM specification before JOIN #69

Closed
elazar opened this issue May 28, 2015 · 4 comments
Closed

Remove restriction requiring FROM specification before JOIN #69

elazar opened this issue May 28, 2015 · 4 comments

Comments

@elazar
Copy link
Contributor

elazar commented May 28, 2015

Presently, when building a SELECT statement, from() must be called before join(). My understanding is that this is more for semantic (i.e. JOIN essentially being a sub-clause of FROM) than logical / logistical reasons. There are use cases that would be supported by not having this restriction.

While I may attempt implementing this myself at some point, I'm uncertain of how soon that will be. As such, I'm filing this issue in case anyone else runs into the same situation and/or wants to try to implement it themselves.

@pmjones
Copy link
Member

pmjones commented May 19, 2016

Well, it's been a year. @elazar do you feel this is still something that's needed? Or is it a doc fix, where we say "you must call from() before join()" ?

@elazar
Copy link
Contributor Author

elazar commented May 19, 2016

I'd call it a "nice to have." If a code change isn't made, a doc change probably should be.

pmjones pushed a commit that referenced this issue May 19, 2016
…t from. if no from is ever added, the joins will never be built into the statement. refs #69, #90.
@pmjones
Copy link
Member

pmjones commented May 19, 2016

@elazar Please review PR #96 , which is an attempt at fixing this issue.

@pmjones
Copy link
Member

pmjones commented May 20, 2016

Fixed by #96; please open a new issue if it doesn't work the way it should. Thanks!

@pmjones pmjones closed this as completed May 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants