Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable PHP 8.2 compat #218

Merged
merged 2 commits into from
Aug 4, 2022
Merged

Enable PHP 8.2 compat #218

merged 2 commits into from
Aug 4, 2022

Conversation

koriym
Copy link
Member

@koriym koriym commented Aug 3, 2022

There are no changes in the source code. The current release 3.1.0 also works fine with PHP 8.2. This PR is just a fix for a problem in the test code in PHP8.2.

@see https://wiki.php.net/rfc/deprecate_dynamic_properties

Copy link
Member

@harikt harikt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from that looks good to me.

tests/FakeObject.php Show resolved Hide resolved
@harikt
Copy link
Member

harikt commented Aug 4, 2022

Can you send to 3.x also?

@harikt harikt marked this pull request as ready for review August 4, 2022 05:29
@harikt harikt merged commit dc69f02 into auraphp:5.x Aug 4, 2022
@koriym koriym mentioned this pull request Aug 4, 2022
@koriym koriym deleted the php8.2-support branch August 4, 2022 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants