Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GitHub Actions for 5.x #198

Merged
merged 1 commit into from
Nov 12, 2021
Merged

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Nov 10, 2021

#197 for 5.x.
Closes #195

@kenjis
Copy link
Member Author

kenjis commented Nov 10, 2021

https://scrutinizer-ci.com/g/auraphp/Aura.Sql/inspections/1bbcbf63-9759-431c-ab01-81bf5fc86260

composer install --no-interaction --no-scripts
inferred 00:02
The command exited with code 2.

Loading composer repositories with package information
Warning from https://repo.packagist.org: Support for Composer 1 is deprecated and some packages will not be available. You should upgrade to Composer 2. See https://blog.packagist.com/deprecating-composer-1-support/
Updating dependencies (including require-dev)
Your requirements could not be resolved to an installable set of packages.

  Problem 1
    - This package requires php >=8.1 but your PHP version (7.3.15) does not satisfy that requirement.

@kenjis
Copy link
Member Author

kenjis commented Nov 10, 2021

@koriym Do you know why scrutinizer uses PHP runtime 7.3.15?

@koriym
Copy link
Member

koriym commented Nov 10, 2021

Because it's cached. Besides, They don't provide an image of PHP 8.1, so you'll have to ignore it or install it to solve the problem.

@brandonsavage
Copy link
Contributor

Does this project really need the bloat of Scrutinizer when we could simply run Psalm or Stan on this?

@koriym
Copy link
Member

koriym commented Nov 10, 2021

@brandonsavage The scrutinizer gives you a score for the complexity of the method, which phpstan/psalm doesn't have. It's a feature I like.

But if it's too much of a hassle to maintain, I guess we can remove it.

@kenjis
Copy link
Member Author

kenjis commented Nov 10, 2021

so you'll have to ignore it or install it to solve the problem.

Will ignoring and waiting solve the problem?
I don't know how to install PHP 8.1.

@kenjis
Copy link
Member Author

kenjis commented Nov 12, 2021

If we don't merge this PR, the GitHub Actions will fail all the time, so I'll merge it anyway.

@kenjis kenjis merged commit 0fd71a5 into auraphp:5.x Nov 12, 2021
@kenjis kenjis deleted the fix-github-actions branch November 12, 2021 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants