Compatibility with PHP 8.1 #193

srjlewis · 2021-10-28T22:22:17Z

Add typing and compatibility with PHP 8.1

I have also pulled in #191

* allow psr/log v2 widens the restriction for which logger interface to use. similar to how symfony handles this: https://github.com/symfony/console/blob/5.3/composer.json#L34

# Conflicts: # composer.json

kenjis · 2021-11-02T08:14:45Z

@koriym Can you review?

composer.json

Co-authored-by: kenjis <[email protected]>

.github/workflows/tests.yml

Co-authored-by: kenjis <[email protected]>

By default PDO now uses native types for int/floats instead of everything being strings.

src/ConnectionLocator.php

…ctionNotFound from getDefault() on a null default

srjlewis

Add a extra test, all looks good

Co-authored-by: kenjis <[email protected]>

src/PdoInterface.php

Co-authored-by: kenjis <[email protected]>

src/PdoInterface.php

src/AbstractExtendedPdo.php

kenjis · 2021-11-07T09:45:02Z

Could you update the config file of PHPUnit?

PHPUnit 9.5.10 by Sebastian Bergmann and contributors.

  Warning - The configuration file did not pass validation!
  The following problems have been detected:

  Line 3:
  - Element 'testsuite': The attribute 'name' is required but missing.

  Line 7:
  - Element 'filter': This element is not expected.

  Test results may not be as expected.

…thod.

kenjis · 2021-11-08T09:46:25Z

We tried to match the PDO method signatures in the PHP manual as much as possible.

kenjis · 2021-11-08T09:47:42Z

@srjlewis Thank you!

kenjis · 2021-11-10T03:53:25Z

Close #192

Werner Spiegel and others added 9 commits October 17, 2021 19:48

allow psr/log v2 (#191)

2754f95

* allow psr/log v2 widens the restriction for which logger interface to use. similar to how symfony handles this: https://github.com/symfony/console/blob/5.3/composer.json#L34

php 8.1 support

8600f89

Merge remote-tracking branch 'origin/3.x-actions' into 5.x-php8.1

8ec00b9

php 8.1 support

1ea6b17

php 8.1 support

3669624

php 8.1 support

9861463

Merge remote-tracking branch 'origin/3.x' into 5.x-php8.1

3befb1e

# Conflicts: # composer.json

Remove JetBrains\PhpStorm\ArrayShape usage

7050fa0

Fixing regression in composer.json with phpunit

b2989f9

srjlewis mentioned this pull request Oct 28, 2021

PHP 8.1 Compatibility #192

Closed

correctly set minimum php version in composer

7fccf1b

kenjis reviewed Nov 3, 2021

View reviewed changes

composer.json Outdated Show resolved Hide resolved

Update composer.json to php 8.1

579e653

Co-authored-by: kenjis <[email protected]>

kenjis reviewed Nov 3, 2021

View reviewed changes

.github/workflows/tests.yml Outdated Show resolved Hide resolved

srjlewis and others added 2 commits November 3, 2021 10:13

Update .github/workflows/tests.yml to only test on with php 8.1

4eb418b

Co-authored-by: kenjis <[email protected]>

Update test for a change in behavior

2eb4485

By default PDO now uses native types for int/floats instead of everything being strings.

koriym approved these changes Nov 4, 2021

View reviewed changes

src/ConnectionLocator.php Show resolved Hide resolved

srjlewis added 2 commits November 4, 2021 08:50

correct docblock to match type

04b6657

test null default connection within ConnectionLocator and throw Conne…

42146a0

…ctionNotFound from getDefault() on a null default

srjlewis commented Nov 4, 2021

View reviewed changes

srjlewis and others added 4 commits November 7, 2021 09:02

Update src/PdoInterface.php

9d66473

Co-authored-by: kenjis <[email protected]>

Update src/PdoInterface.php

421633f

Co-authored-by: kenjis <[email protected]>

Update src/PdoInterface.php

4b84240

Co-authored-by: kenjis <[email protected]>

Update src/PdoInterface.php

8de43af

Co-authored-by: kenjis <[email protected]>

kenjis reviewed Nov 7, 2021

View reviewed changes

src/PdoInterface.php Outdated Show resolved Hide resolved

srjlewis and others added 4 commits November 7, 2021 09:10

Update src/PdoInterface.php

48914ec

Co-authored-by: kenjis <[email protected]>

Update src/PdoInterface.php

52b5340

Co-authored-by: kenjis <[email protected]>

Update src/AbstractExtendedPdo.php

aa574c9

Co-authored-by: kenjis <[email protected]>

Apply suggestions from code review

77746c2

Co-authored-by: kenjis <[email protected]>

kenjis reviewed Nov 7, 2021

View reviewed changes

src/PdoInterface.php Outdated Show resolved Hide resolved

kenjis reviewed Nov 7, 2021

View reviewed changes

src/PdoInterface.php Outdated Show resolved Hide resolved

kenjis reviewed Nov 7, 2021

View reviewed changes

src/PdoInterface.php Outdated Show resolved Hide resolved

kenjis reviewed Nov 7, 2021

View reviewed changes

src/PdoInterface.php Outdated Show resolved Hide resolved

kenjis reviewed Nov 7, 2021

View reviewed changes

src/PdoInterface.php Outdated Show resolved Hide resolved

kenjis reviewed Nov 7, 2021

View reviewed changes

src/PdoInterface.php Outdated Show resolved Hide resolved

kenjis reviewed Nov 7, 2021

View reviewed changes

src/PdoInterface.php Outdated Show resolved Hide resolved

kenjis reviewed Nov 7, 2021

View reviewed changes

src/AbstractExtendedPdo.php Outdated Show resolved Hide resolved

kenjis reviewed Nov 7, 2021

View reviewed changes

src/AbstractExtendedPdo.php Outdated Show resolved Hide resolved

kenjis reviewed Nov 7, 2021

View reviewed changes

src/AbstractExtendedPdo.php Outdated Show resolved Hide resolved

kenjis reviewed Nov 7, 2021

View reviewed changes

src/AbstractExtendedPdo.php Outdated Show resolved Hide resolved

kenjis reviewed Nov 7, 2021

View reviewed changes

src/AbstractExtendedPdo.php Outdated Show resolved Hide resolved

kenjis reviewed Nov 7, 2021

View reviewed changes

src/AbstractExtendedPdo.php Outdated Show resolved Hide resolved

kenjis reviewed Nov 7, 2021

View reviewed changes

src/AbstractExtendedPdo.php Outdated Show resolved Hide resolved

srjlewis added 2 commits November 7, 2021 10:29

update phpunit config

e324cc0

re-add PdoInterface::getAvailableDrivers() and add a test for this me…

fcd128a

…thod.

kenjis merged commit 2c39cd2 into auraphp:5.x Nov 8, 2021

kenjis mentioned this pull request Nov 8, 2021

Update PHPDoc #196

Merged

srjlewis deleted the 5.x-php8.1 branch November 8, 2021 10:07

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Compatibility with PHP 8.1 #193

Compatibility with PHP 8.1 #193

srjlewis commented Oct 28, 2021

kenjis commented Nov 2, 2021

srjlewis left a comment

kenjis commented Nov 7, 2021

kenjis commented Nov 8, 2021

kenjis commented Nov 8, 2021

kenjis commented Nov 10, 2021

Compatibility with PHP 8.1 #193

Compatibility with PHP 8.1 #193

Conversation

srjlewis commented Oct 28, 2021

kenjis commented Nov 2, 2021

srjlewis left a comment

Choose a reason for hiding this comment

kenjis commented Nov 7, 2021

kenjis commented Nov 8, 2021

kenjis commented Nov 8, 2021

kenjis commented Nov 10, 2021