Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove unused param in queryparser #180

Merged
merged 1 commit into from
Jan 31, 2020
Merged

remove unused param in queryparser #180

merged 1 commit into from
Jan 31, 2020

Conversation

r4ndsen
Copy link

@r4ndsen r4ndsen commented May 17, 2019

No description provided.

@harikt harikt requested a review from pmjones May 21, 2019 15:32
@harikt
Copy link
Member

harikt commented May 21, 2019

Apart from hhvm issue on travis rest looks good. Not sure why there was $sub used and whether it is missed. So requesting @pmjones for review.

@r4ndsen
Copy link
Author

r4ndsen commented May 21, 2019

Apart from hhvm issue on travis rest looks good. Not sure why there was $sub used and whether it is missed. So requesting @pmjones for review.

that was what i looked up first, but the param isnt used in either of the child classes that are derived from that.
i found this from using rector's dead-code analysis

@harikt harikt merged commit 71d6eeb into auraphp:3.x Jan 31, 2020
@harikt
Copy link
Member

harikt commented Jan 31, 2020

Sorry for being late. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmjones pmjones Awaiting requested review from pmjones

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@r4ndsen @harikt