Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slightly tweak ffmpeg version parsing #38

Conversation

DoctorVanGogh
Copy link

Allows some more (custom) ffmpeg builds to be used.

Now correctly parses builds like

FFmpeg 64-bit static Windows build from www.gyan.dev

Version: 4.3.1-2020-10-01-full_build-www.gyan.dev

@audiamus
Copy link
Owner

If I remember correctly, I formulated the REGEX pattern this way with the explicit intention to allow official release builds only, no development builds, no pre-releases or external builds (with the expectation that all builds stick to the ffmpeg version numbering conventions).

AAX Audio Converter makes a few assumptions on functional behavior and relies on precise output format, as you will have seen from the other REGEX patterns. I thought the safest way would be to restrict the versions that will be accepted.

@DoctorVanGogh
Copy link
Author

Well, it doesn't really get any more official than the builds listed by ffmpeg.org

image

And they just happen to tag their builds [major].[minor].[revision]-[date or git-sha]... as I quoted in my fist post.

image


Having said that, I completely agree with your stance on strict parsing. I've done some (private) media conversion scripts which translate ffpmeg -stats console output into powershell progress bars so I know where that is coming from ;)

Nonetheless I think this particular regex could hardly do any harm. You're already not dependent on any "post" version information, you're just enforcing that that information is separated via whitespace.

If you're concerned about increased support requests due to unexpected ffmpeg builds, well, you could always put in a Allow tagged ffmpeg builds checkbox into options and toggle between version parsing via that.

@audiamus
Copy link
Owner

audiamus commented Dec 1, 2020

For the moment I will leave it as it is. For the next release I will add an option for less restrictive FFmpeg version parsing as you suggest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants