Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in USB Cutout position #10

Open
Aapjes94 opened this issue Jan 19, 2021 · 8 comments
Open

Bug in USB Cutout position #10

Aapjes94 opened this issue Jan 19, 2021 · 8 comments
Assignees
Labels
bug Something isn't working

Comments

@Aapjes94
Copy link

Hi,

Thanks for the in-depth guide. I'm preparing for a build with an extra row, as I really need a number row. While adding the finger positions and moving the cut-outs for the cables I think I found a bug.

The right case half didn't match the left one and in modules/rightCase.scad on line 38 I found
PCB_UNDERSIDE_CLEARANCE - MCU_PCB_OFFSET - MCU_PCB_THICKNESS - USB_C_SIZE.z / 2 + 5],

The corresponding line for the left case seems to be the correct one.
PCB_UNDERSIDE_CLEARANCE - max(MCU_PCB_OFFSET, USB_C_SIZE.z) + USB_C_SIZE.z / 2]

@atulloh
Copy link
Owner

atulloh commented Jan 19, 2021

Thanks @Aapjes94 ; I'll have a look. That +5 looks a bit weird, but I was tweaking those cutouts towards the end, so I probably hacked it a little.

One thing to note is that when using a PCB and Elite-C/Pro Micro, when switching sides, the USB port flips direction. e.g.
image

If you are adding an extra row, are you planning to hand wire? If so, it's not as much as an issue, you can probably put the cutouts wherever you want really.

@atulloh atulloh added the bug Something isn't working label Jan 19, 2021
@atulloh atulloh self-assigned this Jan 19, 2021
@Aapjes94
Copy link
Author

Thanks for pointing out the USB positions, hadn't thought about that yet. I thought that the point of the Elite-C/ProMicro was that the USB port was centered on the microcontroller, but it seems to be ever so slightly (0.8 mm) offset. With a small spacer on the left side, it should be possible to get the USB at a constant distance from the PCB.
image

I have never designed a PCB before so would really like to go that way, however, I'll have to figure out how hard that is going to be on the way. I'll probably give it a go and if the PCB fails, I'll go with handwriting. If this all ends up working I'll share the files with you.

@atulloh
Copy link
Owner

atulloh commented Jan 20, 2021

Oh ok. Yes I used an v3.1 Elite-C, and it wasn't quite the same offsets. I'll update the case code accordingly.

atulloh added a commit that referenced this issue Jan 20, 2021
Add USB cutout option for Elite-C v4
@atulloh
Copy link
Owner

atulloh commented Jan 20, 2021

I've added some new code and named case files on a fix branch, here:

https://github.com/atulloh/oddball/tree/fix/10-elite-c-cutout/output/case/v2.0

I've linked these with a little explanation in the build guide's Bill of Materials under the case/MCU sections.

When I get around to ordering a v4 Elite-C, or hear back from someone that the new case files worked, I'll merge this in and close.

@atulloh
Copy link
Owner

atulloh commented Feb 2, 2021

When I get around to ordering a v4 Elite-C, or hear back from someone that the new case files worked, I'll merge this in and close.

Ordered! I should have one to test out in the next week or so.

@Aapjes94
Copy link
Author

Aapjes94 commented Feb 3, 2021

I hope you don't mind it's a bit off-topic, but tangentially related to an earlier comment. Would you be comfortable sharing the file you used to create the PCB files? I think I'd like to take a crack at using a PCB instead of hand wiring this thing with the extra row.

@atulloh
Copy link
Owner

atulloh commented Feb 4, 2021

I hope you don't mind it's a bit off-topic, but tangentially related to an earlier comment. Would you be comfortable sharing the file you used to create the PCB files? I think I'd like to take a crack at using a PCB instead of hand wiring this thing with the extra row.

Sure. I wasn't planning to open sourcing it; I might go down the track of trying to improve it and make some for sale. To be honest, this was my first PCB and isn't the best, and breaks some basic design principles. I can send you the project; add me on Discord (tullonator#6580) or send me at email to alexandertulloh at gmail dot com and I'll get back to you.

@pannet1
Copy link

pannet1 commented Sep 9, 2023

when is this going to be available for sale

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants