Rails 7 support

[movermeyer]

What are you trying to accomplish?

Fixes #423.

Rails 7 introduced Active Record Encryption, which has names that collide with the names that attr_encrypted is using.

What approach did you choose and why?

I took over @ryosk7, @kineca, and @armiiller's closed PR, rebased it on latest master, and recreated it here.

It's a simple rename of class variables and methods, adding a attr_encrypted_ prefix to each.

IMO, it's a perfectly cromulent rename.

What should reviewers focus on?

This is a breaking change, since anyone relying on these names will have to update their code.

The impact of these changes

attr_encrypted will work once again on Rails 7

[xjunior]

Can you add rails 6 and 7 to the test matrix?

[xjunior]

I think we'll need a smarter matrix. Rails 7 isn't compatible with ruby <3.1.

[movermeyer]

I think we'll need a smarter matrix. Rails 7 isn't compatible with ruby <3.1.

@xjunior Also might be a good time to migrate to GitHub Actions?

[movermeyer]

Also, it seems that set_attribute_was was removed in Rails 6.

[jayakrishnang]

Hi @movermeyer, is there any workaround that you suggest we could try here?

[TheStranjer]

For what it's worth, this at least appears to work.

[jayakrishnang]

True, we could probably look at this patch to fix the set_attribute_was situation.
salsify#1

[mdh]

I think we'll need a smarter matrix. Rails 7 isn't compatible with ruby <3.1.

From what I can see >= 2.7 is fine:
https://github.com/rails/rails/blob/v7.0.4/rails.gemspec#L12

[joshbranham]

I was working with @mvastola but have been a bit busy. The idea was to cut a new major release for this breaking change and let rails 7 users upgrade. There is some discussion around how much we should maintain previous versions of this library for older Ruby and ActiveRecord versions. Fwiw we are using this exact patch on a fork at my company to get onto Rails 7, then figuring out how to migrate the data and move to native Rails encryption.

[joshbranham]

True, we could probably look at this patch to fix the set_attribute_was situation. salsify#1

I am working to pull that in here #427

[guillaumebriday-pa]

I was working with @mvastola but have been a bit busy. The idea was to cut a new major release for this breaking change and let rails 7 users upgrade. There is some discussion around how much we should maintain previous versions of this library for older Ruby and ActiveRecord versions. Fwiw we are using this exact patch on a fork at my company to get onto Rails 7, then figuring out how to migrate the data and move to native Rails encryption.

Hi @joshbranham! First, thanks for your awesome work 👍

Do you have any idea when this could be released, to upgrade to Rails 7?

Thanks

[joshbranham]

The current blocker is set_attribute_was doesn't work in >= 6 Activerecord. In removing it's support, some of the tests now fail per #431

I haven't had much luck understanding why those tests exist, and if anyone is using #attr_was style methods via attr_encrypted. I assume they are, but the way this all works feels brittle. So if you wanted to take a look at that, we could get tests passing and merge this and then you could at minimum use the commit off master.