Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow zero-value bids from MEV relays. #275

Closed
wants to merge 1 commit into from
Closed

Allow zero-value bids from MEV relays. #275

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ dev:
- use multisign for sync committee selections with enabled accounts
- use multisign for contributions and proofs with enabled accounts
- use multisign for signing slot selections with enabled accounts
- allow zero-value bids from MEV relays

1.9.2:
- update go-eth2-wallet-dirk to enable mixed signing thresholds for multisign
Expand Down
6 changes: 0 additions & 6 deletions strategies/builderbid/best/builderbid.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,9 +40,6 @@ import (
// zeroExecutionAddress is used for comparison purposes.
var zeroExecutionAddress bellatrix.ExecutionAddress

// zeroValue is used for comparison purposes.
var zeroValue uint256.Int

type builderBidResponse struct {
provider builderclient.BuilderBidProvider
bid *builderspec.VersionedSignedBuilderBid
Expand Down Expand Up @@ -434,9 +431,6 @@ func (*Service) getBidValue(_ context.Context,
if err != nil {
return nil, errors.Wrap(err, "failed to obtain bid value")
}
if zeroValue.Cmp(value) == 0 {
return nil, errors.New("bid has 0 value")
}

return value, nil
}
Expand Down
6 changes: 0 additions & 6 deletions strategies/builderbid/deadline/builderbid.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,9 +42,6 @@ import (
// zeroExecutionAddress is used for comparison purposes.
var zeroExecutionAddress bellatrix.ExecutionAddress

// zeroValue is used for comparison purposes.
var zeroValue uint256.Int

type builderBidResponse struct {
provider builderclient.BuilderBidProvider
bid *builderspec.VersionedSignedBuilderBid
Expand Down Expand Up @@ -496,9 +493,6 @@ func (*Service) getBidValue(_ context.Context,
if err != nil {
return nil, errors.Wrap(err, "failed to obtain bid value")
}
if zeroValue.Cmp(value) == 0 {
return nil, errors.New("bid has 0 value")
}

return value, nil
}
Expand Down