Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: (v1.0.3) ESP32 support #3

Merged
merged 5 commits into from
Aug 28, 2024
Merged

feat: (v1.0.3) ESP32 support #3

merged 5 commits into from
Aug 28, 2024

Conversation

JeremyTubongbanua
Copy link
Member

@JeremyTubongbanua JeremyTubongbanua commented Aug 26, 2024

- What I did

  • Updated uuid4 to v1.0.3 in CMakeLists.txt
  • Added ESP32 support using preprocessor functions in uuid4.c
  • Added ESP32 support in CMakeLists.txt

- How to verify it

Here's proof of UUID4 generation on ESP32

#include <stdio.h>
#include <string.h>
#include <atclient/atclient.h>
#include <atchops/uuid.h>

void app_main(void) {
    printf("Hello, World!\n");

    atchops_uuid_init();

    char my_str[90];
    memset(my_str, 0, sizeof(char) * 90);

    atchops_uuid_generate(my_str, 90);

    printf("UUID: %s\n", my_str);
}

image

- Description for the changelog
feat: ESP32 support

@JeremyTubongbanua JeremyTubongbanua self-assigned this Aug 26, 2024
@JeremyTubongbanua JeremyTubongbanua changed the title feat: updated CMakeLists.txt feat: ESP32 support Aug 26, 2024
@JeremyTubongbanua JeremyTubongbanua marked this pull request as ready for review August 26, 2024 18:29
@JeremyTubongbanua JeremyTubongbanua changed the title feat: ESP32 support feat: (v1.0.3) ESP32 support Aug 26, 2024
@JeremyTubongbanua
Copy link
Member Author

Upon approval, we should:

  1. Make a v1.0.3 release
  2. Update at_c/packages/atchops dependency to use the new release

@JeremyTubongbanua
Copy link
Member Author

Putting back to draft. I want to first add idf_component.yml

@JeremyTubongbanua JeremyTubongbanua marked this pull request as draft August 26, 2024 18:53
@JeremyTubongbanua JeremyTubongbanua marked this pull request as ready for review August 26, 2024 19:27
@JeremyTubongbanua
Copy link
Member Author

Ready for review

@realvarx
Copy link

LGTM

idf_component.yml Outdated Show resolved Hide resolved
@JeremyTubongbanua JeremyTubongbanua merged commit 47974d0 into trunk Aug 28, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants