Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: c-protected-header-files decision #216

Draft
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

XavierChanth
Copy link
Member

@XavierChanth XavierChanth commented Jan 3, 2025

- What I did

  • Added a new decision log, please read the document

- How I did it

- How to verify it

- Description for the changelog
docs: c-protected-header-files decision

@XavierChanth
Copy link
Member Author

Will discuss tomorrow on call

@XavierChanth XavierChanth requested a review from cconstab January 7, 2025 15:38
Copy link
Member

@cpswan cpswan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@XavierChanth what's your preferred option (and why)?

I think it's fine to go into these things with an answer (and other things that were considered). Maybe it surfaces additional reasons for the other options to be (re)considered, but generally I think people will be happy to go with the suggested approach.

As I recall, the purpose of this ADR was to leave a record of why we started doing the thing, so let's not agonise too much over how we do it.

@XavierChanth
Copy link
Member Author

@XavierChanth what's your preferred option (and why)?

I think it's fine to go into these things with an answer (and other things that were considered). Maybe it surfaces additional reasons for the other options to be (re)considered, but generally I think people will be happy to go with the suggested approach.

As I recall, the purpose of this ADR was to leave a record of why we started doing the thing, so let's not agonise too much over how we do it.

My plan is to try A, and see if it reasonably fulfills our needs, if not, we can try B or another option if it appears. Once we have a clear answer, I'll update the document.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants