Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rsa.decrypt
was always failing as this test always returned true:It seems that the leading characters for the cleartext we're getting are b' \x02' - a space instead of a null
This isn't happening at the padding stage before encryption, which is correct. But I've not been able to track down where that b'\x20' is creeping in.
- What I did
Allow the test to pass when it finds b' \x02' (as well as b'\x00\x02')
Also added pycache to .gitignore
- How I did it
Looked at raw cleartext to see why the test was failing and observed a leading space rather than the null that should be there.
- How to verify it
- Description for the changelog
fix: Get rsa.decrypt working