feat: Added support for easy connection to an AtSecondaryReverseProxy #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Feat: Enhanced SecondaryUrlFinder so by convention it will return a secondary address of <proxy domain>:<'root' port> when rootDomain is supplied as 'proxy:<proxy domain>' and 'rootPort' is supplied as the port on which the reverse proxy is listening Test: Added tests to verify behaviour of CacheableSecondaryAddressFinder with rootDomain set to 'proxy:<something>'
gkc
changed the title
Feat: Enhanced SecondaryUrlFinder so by convention it will return a secondary address of <proxy domain>:<'root' port> when rootDomain is supplied as 'proxy:<proxy domain>' and 'rootPort' is supplied as the port on which the reverse proxy is listening Test: Added tests to verify behaviour of CacheableSecondaryAddressFinder with rootDomain set to 'proxy:<something>'
murali-shris
approved these changes
Jul 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Feat: Enhanced SecondaryUrlFinder so by convention it will return a secondary address of
<proxy domain>:<'root' port>when rootDomain is supplied as'proxy:<proxy domain>'and'rootPort'is supplied as the port on which the reverse proxy is listeninge.g. rootDomain of 'proxy:vip.ve.atsign.zone' and rootPort of '8443' will result in all secondary lookups returning the same address, being the address of the proxy :
vip.ve.atsign.zone:8443in this exampleTest: Added tests to verify behaviour of CacheableSecondaryAddressFinder with rootDomain set to 'proxy:'
- How to verify it
Tests should pass. For end-to-end full verification, see instructions here for setting up an AtSecondaryServer reverse proxy
- Description for the changelog
Feat: Added support for easy connection to an AtSecondaryReverseProxy