Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated docs for at_contact library #131

Merged
merged 5 commits into from
Feb 24, 2022
Merged

updated docs for at_contact library #131

merged 5 commits into from
Feb 24, 2022

Conversation

yahu1031
Copy link
Member

@yahu1031 yahu1031 commented Jan 2, 2022

- What I did

  • Update the at_contact library documentation(README.md) W.R.T flutter

- How I did it

  • Cloned, created branch, updated.

- How to verify it

- Description for the changelog

Usage of the library update.

@yahu1031 yahu1031 marked this pull request as draft January 2, 2022 18:59
@yahu1031
Copy link
Member Author

yahu1031 commented Jan 2, 2022

I need to get confirmation about the example app for this library.

@murali-shris murali-shris self-requested a review January 3, 2022 06:51
@murali-shris
Copy link
Member

keep the readme simple with only dart usage..flutter snippets can be part of at_contacts_flutter

Copy link
Member

@CynthiaPeter CynthiaPeter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we change "Initially to get a basic overview of the @protocol packages, You must read the atsign docs." to

Also, it is important we include tags and keywords.

@gkc
Copy link
Contributor

gkc commented Feb 23, 2022

@yahu1031 this was approved but not merged; shall you merge it to trunk?

@yahu1031
Copy link
Member Author

yahu1031 commented Feb 23, 2022

@gkc Uh oh! Really sorry I thought it was merged. Lemme just go through the code again cause things have little changes from then to now.

@yahu1031 yahu1031 requested a review from gkc February 24, 2022 09:50
at_contact/README.md Outdated Show resolved Hide resolved
@gkc gkc merged commit d6062a9 into trunk Feb 24, 2022
@sitaram-kalluri sitaram-kalluri deleted the docs_update branch April 20, 2022 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants