Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run travis tests against 3 different ansible versions #7

Merged
merged 1 commit into from
Jun 25, 2018

Conversation

paulfantom
Copy link
Collaborator

@atosatto can we remove test-requirements.txt?

@paulfantom paulfantom requested review from SuperQ and atosatto and removed request for SuperQ June 25, 2018 08:55
Copy link
Collaborator

@SuperQ SuperQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I think we can drop the test-requirements.txt file now.

.travis.yml Outdated
install:
- pip install -r test-requirements.txt
- pip install ${ANSIBLE} 'molecule>=2.15.0' docker 'ansible-lint>=3.4.0' 'testinfra>=1.7.0'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the docker package already includes molecule now, we can probably drop that as well.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docker package includes molecule? That doesn't seem to be right.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, the images used for testing, ie. image: paulfantom/centos-molecule already include it.

Copy link
Collaborator Author

@paulfantom paulfantom Jun 25, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But docker is needed by ansible to provision this image. CI fails without it (https://travis-ci.org/atosatto/ansible-minio/builds/396310266)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I meant removing the molecule package, not the docker package. But I guess those are not included in the base travis image.

Nevermind!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, molecule isn't installed by default in travis.

@atosatto
Copy link
Owner

Why don't we use tox as done, e.g., in http://github.com/atosatto/ansible-caddy?

@paulfantom
Copy link
Collaborator Author

I don't have much experience with tox. @atosatto can you parallelize tox execution over multiple travis instances?

@paulfantom
Copy link
Collaborator Author

@atosatto tox looks so much better! I need to port it to @cloudalchemy 😄

@atosatto
Copy link
Owner

😄

@paulfantom
Copy link
Collaborator Author

I don't see any protests, merging :)

@paulfantom paulfantom merged commit b05757b into atosatto:master Jun 25, 2018
@paulfantom paulfantom deleted the multiple_ansible_versions branch June 25, 2018 11:23
akire0ne pushed a commit to akire0ne/ansible-minio that referenced this pull request Feb 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants