-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run travis tests against 3 different ansible versions #7
Run travis tests against 3 different ansible versions #7
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I think we can drop the test-requirements.txt file now.
.travis.yml
Outdated
install: | ||
- pip install -r test-requirements.txt | ||
- pip install ${ANSIBLE} 'molecule>=2.15.0' docker 'ansible-lint>=3.4.0' 'testinfra>=1.7.0' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the docker package already includes molecule now, we can probably drop that as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Docker package includes molecule? That doesn't seem to be right.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, the images used for testing, ie. image: paulfantom/centos-molecule
already include it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But docker
is needed by ansible to provision this image. CI fails without it (https://travis-ci.org/atosatto/ansible-minio/builds/396310266)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, I meant removing the molecule package, not the docker package. But I guess those are not included in the base travis image.
Nevermind!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, molecule isn't installed by default in travis.
Why don't we use tox as done, e.g., in http://github.com/atosatto/ansible-caddy? |
I don't have much experience with tox. @atosatto can you parallelize tox execution over multiple travis instances? |
729b10f
to
3d98143
Compare
@atosatto tox looks so much better! I need to port it to @cloudalchemy 😄 |
😄 |
I don't see any protests, merging :) |
docker
package instead ofdocker-py
as it was renamed (http://docker-py.readthedocs.io/en/stable/)@atosatto can we remove test-requirements.txt?