Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename client/server install flags. #5

Merged
merged 1 commit into from
Jun 25, 2018
Merged

Rename client/server install flags. #5

merged 1 commit into from
Jun 25, 2018

Conversation

SuperQ
Copy link
Collaborator

@SuperQ SuperQ commented Jun 25, 2018

  • Use minio namespace.
  • Use positive bool flag to avoid confusing double negative.

Rename client/server install flags.
e86f6f8 
* Use minio namespace.
* Use positive bool flag to avoid confusing double negative.
@SuperQ SuperQ requested a review from atosatto June 25, 2018 07:04
@atosatto
Copy link
Owner

LGTM

@SuperQ SuperQ merged commit 30dcb8b into atosatto:master Jun 25, 2018
@SuperQ SuperQ deleted the bool_flags branch June 25, 2018 07:10
@SuperQ SuperQ mentioned this pull request Jun 25, 2018
Closed
akire0ne pushed a commit to akire0ne/ansible-minio that referenced this pull request Feb 15, 2022
@sebastian-schmid
change MINIO_ROOT_USERNAME to MINIO_ROOT_USER (atosatto#5)
ac43121
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atosatto atosatto atosatto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SuperQ @atosatto