Add 'minio_server_release' and 'minio_client_release' variables. #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
sberthier
commented
Jul 1, 2019
sberthier
commented
- Default = "" = lastest
SuperQ
reviewed
Jul 1, 2019
tasks/install-server.yml
Outdated
| @@ -1,8 +1,17 @@ | |||
| --- | |||
| - name: Compose the Minio server download base url | |||
| set_fact: | |||
| _minio_server_download_base_url: "https://dl.minio.io/server/minio/release/linux-{{ go_arch_map[ansible_architecture] | default(ansible_architecture) }}" | |||
There was a problem hiding this comment.
Rather than use this go_arch_map evaluation here, use it in a vars entry.
Similar to we do it in ansible-prometheus.
There was a problem hiding this comment.
Actually, let me send that as a separate refactoring PR.
There was a problem hiding this comment.
Effectively, I will wait for your PR to be merged.
There was a problem hiding this comment.
Yea, first need to fix CI with #33. 😄
sberthier
force-pushed
the
install-specified-release-option
branch
from
b303b81
to
8dd04ae
Compare
- Default = "" = lastest
sberthier
force-pushed
the
install-specified-release-option
branch
from
8dd04ae
to
4de97d3
Compare
atosatto
approved these changes
Jul 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.