Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin the version of ferrarimarco/github-changelog-generator to prevent the CI from hanging #26

Merged
merged 1 commit into from
Aug 20, 2018

Conversation

atosatto
Copy link
Owner

Copy link
Collaborator

@paulfantom paulfantom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I forgot about this repo. Most of others already use pinned version.

This is a problem caused by @ferrarimarco, since he pinned latest version to unstable (pre-)release. I am considering forking that repo to control pipeline and not have this issue again.

@atosatto atosatto merged commit 11b391f into master Aug 20, 2018
@atosatto atosatto deleted the fix-travis-releaser branch August 20, 2018 20:21
@atosatto
Copy link
Owner Author

Yeah, indeed it was just the latest tag the problem.
Nevermind, it should be fixed now.

@ferrarimarco
Copy link

Hi all.

The latest tag marks the latest Gem release in our case.

Sorry you discovered the fact (via the hard way :) that in production you should avoid the latest tag and pin a specific version. 👍

@atosatto atosatto added the bug label Aug 31, 2018
@paulfantom
Copy link
Collaborator

paulfantom commented Sep 6, 2018

@ferrarimarco actually that's a matter of balancing your time and your trust in someone else release and upgrade process. For security reasons you should always opt for latest version of the software. However this can cause some stability issues, which could be solved by spending some of your time. Classic chicken and an egg problem 😄
On the other hand there are projects like linux kernel where breaking backwards compatibility is punished (fortunately not by death, but only by angry email from Linus 😄) and you can update your system without much testing before.

As for me I have a lot of trust in software I use for personal projects (hence latest tag), until I am proven otherwise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants