Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion to allow disable create/update the default user/group running minio and, if is created by this role, set create_home: no #43

Closed
fititnt opened this issue Jan 21, 2020 · 2 comments

Comments

@fititnt
Copy link

fititnt commented Jan 21, 2020

- name: Create Minio user
user:
name: "{{ minio_user }}"
group: "{{ minio_group }}"
system: "yes"
shell: "/usr/sbin/nologin"

The PR #41 by @drakmail did not explicitly removed the default ansible behavior of not create the home.

Suggestion to add by default create_home: no

On this case, I agree with @SuperQ to not create home if the user is created by atosatto.ansible-minio. The way to implement this would be add an extra line create_home: no.

Suggestion to allow not manange user/group running minio

The problem with this is that, different from the option to not allow this role create the data dirs with minio_server_make_datadirs: true there is no option to disable management of the user/group. So even if a user define another user/group to run minio, this role may in fact revert options of user created by other roles or tasks.

@atosatto
Copy link
Owner

Hi @fititnt, this sounds like a good idea indeed.
Any chance for you to contribute this in a PR? I will review it and merge it as soon as possible.

@fititnt
Copy link
Author

fititnt commented Jan 23, 2020

@atosatto Sounds like a plan.

It's an easy addition, but I will do some basic tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants